[GitHub] carbondata pull request #1728: [CARBONDATA-1926][Pre-Aggregate] Expression s...

[jackylk]

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1728#discussion_r158934363
  
    --- Diff: 
integration/spark2/src/main/scala/org/apache/spark/sql/hive/CarbonPreAggregateRules.scala
 ---
    @@ -126,16 +127,17 @@ case class CarbonPreAggregateQueryRules(sparkSession: 
SparkSession) extends Rule
                 aggregateExp,
                 carbonTable,
                 tableName,
    -            list)
    -          carbonTable
    +            list,
    +            aggregateExpressions)
    +          (carbonTable, logicalRelation)
     
             // below case for handling filter query
             // When plan has grouping expression, aggregate expression
             // filter expression
             case Aggregate(groupingExp,
    -          aggregateExp,
    -          Filter(filterExp,
    -          CarbonSubqueryAlias(_, logicalRelation: LogicalRelation)))
    +        aggregateExp,
    --- End diff --
    
    unnecessary change


---