Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1728#discussion_r159457864
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/hive/CarbonPreAggregateRules.scala
---
@@ -806,67 +824,105 @@ case class
CarbonPreAggregateQueryRules(sparkSession: SparkSession) extends Rule
val updatedAggExp = aggregateExpressions.map {
--- End diff --
It seems lot of duplicate code, better do transform and use single `case
attr: AttributeReference` handle all here
---
