Github user ravipesala commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1732#discussion_r159461589
  
    --- Diff: 
integration/spark2/src/test/scala/org/apache/spark/carbondata/restructure/vectorreader/ChangeDataTypeTestCases.scala
 ---
    @@ -164,6 +164,21 @@ class ChangeDataTypeTestCases extends Spark2QueryTest 
with BeforeAndAfterAll {
         sql("drop table if exists PreAggMain_preagg1")
       }
     
    +  test("test data type change for dictionary exclude INT type column") {
    --- End diff --
    
    PLease add tests for short to int, short to long and float to double also


---

Reply via email to