Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1743#discussion_r159606539
  
    --- Diff: 
integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/datamap/CarbonDropDataMapCommand.scala
 ---
    @@ -136,6 +137,12 @@ case class CarbonDropDataMapCommand(
         // delete the table folder
         val tableIdentifier = CarbonEnv.getIdentifier(databaseNameOp, 
tableName)(sparkSession)
         DataMapStoreManager.getInstance().clearDataMap(tableIdentifier, 
dataMapName)
    +    CarbonDropTableCommand(
    --- End diff --
    
    Beside CarbonDropDataMapCommand.scala, CarbonDropTableCommand.scala also 
has problem that processMetadata is incorrect if there are datamaps associated 
with the fact table. Please modify that in this PR also.


---

Reply via email to