GitHub user xuchuanyin opened a pull request:
https://github.com/apache/carbondata/pull/1762
[CARBONDATA-1981][Build] Fix compile error in windows env
# Scenario & RootCause
PR #1738 introduced a way to generate version info while building project.
It use bash script in maven, which will cause error in Windows environment.
# Modification
+ Add `windows` profile to support building project in Windows
environment. This profile is disabled by default.
+ If this profile is enabled, a Windows bat will be executed, otherwise a
Unix bash script will be executed by default.
Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily:
- [X] Any interfaces changed?
`No`
- [X] Any backward compatibility impacted?
`No`
- [X] Document update required?
`Yes. README in build module is updated`
- [X] Testing done
Please provide details on
- Whether new unit test cases have been added or why no new tests
are required?
`No, not related`
- How it is tested? Please attach test report.
`Not related`
- Is it a performance related change? Please attach the performance
test report.
`Not related`
- Any additional information to help reviewers in testing this
change.
`No`
- [X] For large changes, please consider breaking it into sub-tasks under
an umbrella JIRA.
`Not related`
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/xuchuanyin/carbondata bug_windows_compile
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/carbondata/pull/1762.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1762
----
commit 82f7b3d118d57a5916f8efe74798be8695598e13
Author: xuchuanyin <xuchuanyin@...>
Date: 2018-01-04T09:21:56Z
Fix compile error in windows env
Add `windows` profile to support building project in Windows
environment. This profile is disabled by default.
----
---
