[GitHub] carbondata pull request #1744: [CARBONDATA-1955] Delta DataType calculation ...

[mohammadshahidkhan]

Github user mohammadshahidkhan commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1744#discussion_r159654010
  
    --- Diff: 
core/src/main/java/org/apache/carbondata/core/datastore/page/encoding/DefaultEncodingFactory.java
 ---
    @@ -216,8 +216,13 @@ private static DataType fitDelta(DataType dataType, 
Object max, Object min) {
         } else if (dataType == DataTypes.INT) {
           value = (long) (int) max - (long) (int) min;
    --- End diff --
    
    As per our discussion for other dataTypes overflow handling not required.


---