Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1758#discussion_r160137111
--- Diff:
core/src/main/java/org/apache/carbondata/core/metadata/schema/table/CarbonTable.java
---
@@ -132,11 +133,42 @@ private CarbonTable() {
this.tablePrimitiveDimensionsMap = new HashMap<String,
List<CarbonDimension>>();
}
+ /**
+ * During creation of TableInfo from hivemetastore the DataMapSchemas
and the columns
+ * DataTypes are not converted to the appropriate child classes.
+ *
+ * This method will cast the same to the appropriate classes
+ *
+ * @param tableInfo
+ */
+ private static void updateTableInfo(TableInfo tableInfo) {
+ List<DataMapSchema> dataMapSchemas = new ArrayList<>();
+ for (DataMapSchema dataMapSchema : tableInfo.getDataMapSchemaList()) {
--- End diff --
Similar code is present in `ThriftWrapperSchemaConverterImpl` also right?
Is it possible to remove from there?
---
