Github user kumarvishal09 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1809#discussion_r161676396
  
    --- Diff: 
core/src/main/java/org/apache/carbondata/core/scan/filter/executer/ExcludeFilterExecuterImpl.java
 ---
    @@ -378,6 +378,9 @@ private BitSet 
setFilterdIndexToBitSet(DimensionColumnDataChunk dimensionColumnD
         BitSet bitSet = new BitSet(numerOfRows);
         bitSet.flip(0, numerOfRows);
         byte[][] filterValues = dimColumnExecuterInfo.getExcludeFilterKeys();
    +    if (filterValues.length == 0) {
    --- End diff --
    
    Please add comment for both Include and exclude when filter can be null


---

Reply via email to