Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1813#discussion_r161963254
--- Diff:
processing/src/main/java/org/apache/carbondata/processing/loading/converter/impl/NonDictionaryFieldConverterImpl.java
---
@@ -70,13 +70,14 @@ public NonDictionaryFieldConverterImpl(DataField
dataField, String nullformat, i
try {
byte[] value = DataTypeUtil
.getBytesBasedOnDataTypeForNoDictionaryColumn(dimensionValue,
dataType, dateFormat);
- if (dataType == DataTypes.STRING) {
- assert value.length <=
CarbonCommonConstants.MAX_CHARS_PER_COLUMN_DEFAULT;
+ if (dataType == DataTypes.STRING
+ && value.length >
CarbonCommonConstants.MAX_CHARS_PER_COLUMN_DEFAULT) {
+ throw new CarbonDataLoadingException("Dataload failed, String
size cannot exceed "
+ + CarbonCommonConstants.MAX_CHARS_PER_COLUMN_DEFAULT + "
bytes");
}
row.update(value, index);
- } catch (AssertionError ae) {
- throw new CarbonDataLoadingException("Dataload failed, String size
cannot exceed "
- + CarbonCommonConstants.MAX_CHARS_PER_COLUMN_DEFAULT + "
bytes");
+ } catch (CarbonDataLoadingException e) {
--- End diff --
Kindly check and confirm if CarbonDataLoadingException can come from any
other place also in this flow
---
