Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1793#discussion_r161985749
  
    --- Diff: 
core/src/main/java/org/apache/carbondata/core/mutate/CarbonUpdateUtil.java ---
    @@ -427,6 +427,10 @@ public static void cleanUpDeltaFiles(CarbonTable 
table, boolean forceDelete) {
     
         String validUpdateStatusFile = "";
     
    +    boolean getOnlyAbortedFiles = true;
    --- End diff --
    
    It is hard to understand a Boolean variable with name start with `get`, can 
you rename it `isXXX` and add comment for it. The same for below variable


---

Reply via email to