GitHub user BJangir opened a pull request:
https://github.com/apache/carbondata/pull/1824
[CARBONDATA-2046]agg Query failed when non supported aggregate is present
in Query
Root Cause :- isValidPlan variable was getting overwritten by
CarbonReflectionUtils.hasPredicateSubquery(expression) .
Solution :- CarbonReflectionUtils.hasPredicateSubquery(expression) method
should be called when isValidPlan is true to avoid overwritten.
Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily:
- [ ] Any interfaces changed? NO
- [ ] Any backward compatibility impacted? NO
- [ ] Document update required?
NO
- [ ] Testing done
Please provide details on
- Whether new unit test cases have been added or why no new tests
are required?
Added UI
- How it is tested? Please attach test report.
- Is it a performance related change? Please attach the performance
test report.
NA
- Any additional information to help reviewers in testing this
change.
NA
- [ ] For large changes, please consider breaking it into sub-tasks under
an umbrella JIRA.
NA
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/BJangir/incubator-carbondata CARBONDATA-2046
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/carbondata/pull/1824.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1824
----
commit 4be2764f415cb50cb8785497500c069c69e9caa2
Author: BJangir <babulaljangir111@...>
Date: 2018-01-17T17:02:10Z
agg Query failed when non supported aggregate is present in Query
----
---
