Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1828#discussion_r162302554
  
    --- Diff: 
integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/management/CarbonCleanFilesCommand.scala
 ---
    @@ -70,11 +70,12 @@ case class CarbonCleanFilesCommand(
           databaseNameOp: Option[String], tableName: String): Unit = {
         val dbName = CarbonEnv.getDatabaseName(databaseNameOp)(sparkSession)
         val databaseLocation = CarbonEnv.getDatabaseLocation(dbName, 
sparkSession)
    +    val tablePath = databaseLocation + 
CarbonCommonConstants.FILE_SEPARATOR + tableName
         CarbonStore.cleanFiles(
           dbName,
           tableName,
    -      databaseLocation,
    -      null,
    +      tablePath,
    +      null, // in case of delete all data carbonTable is not required.
    --- End diff --
    
    can you add parameter name also to make it more readable


---

Reply via email to