GitHub user ravipesala opened a pull request:
https://github.com/apache/carbondata/pull/1872
[TEST-FRAMEWORK] Added test framework to ensure processMeta and processData
methods from Carbon Commands
Problem :
Existing Carbon command framework suppose to ensure that processData
should not access any hive metastore operations and processMetaData and
undoMetaData should not access any file operations.
But there is no test framework to ensure this command calls, so it is very
difficult for developers to follow and ensure this framework.
Solution :
Added a test framework in carbon using mocks to ensure following calls
1. Find all the implemented classes of MetadataCommand, DataCommand and
AtomicRunnableCommand.
2. processMetaData or undoMetaData can access hive metastore but not any
file operations.
3. processData can access file operations but not any hive metastore
This framework is enabled only when carbon hive schema metastore
(spark.carbon.hive.schema.store) is enabled.
After running tests using this framework I find out around 254 tests are
failing. These tests are mostly related to Autocompaction, IUD, Alter table,
partitioning and complex types.
CI Link :
http://136.243.101.176:8080/job/ApacheCarbondataSpark2.1Hadoop2.7.2new/116/
Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily:
- [X] Any interfaces changed?
- [X] Any backward compatibility impacted?
- [X] Document update required?
- [X] Testing done
- [X] For large changes, please consider breaking it into sub-tasks under
an umbrella JIRA.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ravipesala/incubator-carbondata instrument
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/carbondata/pull/1872.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1872
----
commit fe841a30c35b2f2fbb1d5911db35a5695f045da9
Author: ravipesala <ravi.pesala@...>
Date: 2018-01-22T11:11:25Z
Added test framework to ensure processMeta and processData methods from
Carbon Commands
----
---
