Github user sraghunandan commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1865#discussion_r164323056
  
    --- Diff: 
integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/timeseries/TimeSeriesUtil.scala
 ---
    @@ -54,6 +56,107 @@ object TimeSeriesUtil {
         }
       }
     
    +  def getGranularityKey(dmProperties: Map[String, String]): String = {
    --- End diff --
    
    why to return the same value? if required only for validation, can change 
method name and return true/false


---

Reply via email to