Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1878#discussion_r164652985
  
    --- Diff: 
integration/spark-common-test/src/test/scala/org/apache/carbondata/integration/spark/testsuite/preaggregate/TestPreAggCreateCommand.scala
 ---
    @@ -212,6 +212,21 @@ class TestPreAggCreateCommand extends QueryTest with 
BeforeAndAfterAll {
         sql("drop datamap agg0 on table maintable")
       }
     
    +  test("remove agg tables from show table command") {
    +    sql("DROP TABLE IF EXISTS tbl_1")
    +    sql("DROP TABLE IF EXISTS sparktable")
    +    sql("create table if not exists  tbl_1(imei string,age int,mac string 
,prodate timestamp,update timestamp,gamepoint double,contrid double) stored by 
'carbondata' ")
    +    sql("create table if not exists sparktable(a int,b string)")
    +    sql(
    +      s"""create datamap preagg_sum on table tbl_1 using 'preaggregate' as 
select mac,avg(age) from tbl_1 group by mac"""
    +        .stripMargin)
    +    sql(
    +      "create datamap agg2 on table tbl_1 using 'preaggregate' 
DMPROPERTIES ('timeseries" +
    --- End diff --
    
    Please split this testcase into two testcases, one for preaggregation 
datamap, another for time series datamap


---

Reply via email to