Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1772#discussion_r165385686
--- Diff:
processing/src/main/java/org/apache/carbondata/processing/loading/steps/WriterProcessorStepImpl.java
---
@@ -271,37 +262,18 @@ private CarbonRow convertRow(CarbonRow row) throws
KeyGenException {
}
private void processBatch(CarbonRowBatch batch, CarbonFactHandler
dataHandler, int iteratorIndex)
- throws CarbonDataLoadingException {
- try {
- while (batch.hasNext()) {
- CarbonRow row = batch.next();
- CarbonRow converted = convertRow(row);
- dataHandler.addDataToStore(converted);
- readCounter[iteratorIndex]++;
+ {
+ while (batch.hasNext()) {
+ CarbonRow row;
+ if (noSort) {
--- End diff --
ok, fixed
---