Github user manishgupta88 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1914#discussion_r165676157
  
    --- Diff: 
integration/spark-common/src/main/scala/org/apache/carbondata/spark/util/DataLoadingUtil.scala
 ---
    @@ -229,11 +229,11 @@ object DataLoadingUtil {
     
         if (bad_records_logger_enable.toBoolean ||
             LoggerAction.REDIRECT.name().equalsIgnoreCase(bad_records_action)) 
{
    -      bad_record_path = CarbonUtil.checkAndAppendHDFSUrl(bad_record_path)
           if (!CarbonUtil.isValidBadStorePath(bad_record_path)) {
             CarbonException.analysisException("Invalid bad records location.")
           }
         }
    +    bad_record_path = CarbonUtil.checkAndAppendHDFSUrl(bad_record_path)
    --- End diff --
    
    Move the condition up in if block after validation


---

Reply via email to