GitHub user SangeetaGulia opened a pull request:
https://github.com/apache/carbondata/pull/1917
[CARBONDATA-2105] Fixed bug for null values when group by column is present
as dictionary_include
1) Refactored code to resolve issue of null values when group by column is
present as dictionary_include.
2) Added related test case.
Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily:
- [x] Any interfaces changed? No
- [x] Any backward compatibility impacted? No
- [x] Document update required? No
- [x] Testing done
Please provide details on
- Whether new unit test cases have been added or why no new tests
are required?
Yes
- How it is tested? Please attach test report.
- Is it a performance related change? Please attach the performance
test report.
- Any additional information to help reviewers in testing this
change.
- [x] For large changes, please consider breaking it into sub-tasks under
an umbrella JIRA. (NA)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/SangeetaGulia/incubator-carbondata
CARBONDATA-2105
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/carbondata/pull/1917.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1917
----
commit 9755b53e8f91d0e609b45bc155044f1cab278b5f
Author: SangeetaGulia <sangeeta.gulia@...>
Date: 2018-02-02T17:11:24Z
Fixed bug for null values when group by column is present as
dictionary_include
----
---
