Github user ravipesala commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1935#discussion_r166845170
  
    --- Diff: 
hadoop/src/main/java/org/apache/carbondata/hadoop/api/CarbonTableInputFormat.java
 ---
    @@ -1003,4 +1004,13 @@ public static String getTableName(Configuration 
configuration)
         }
         return tableName;
       }
    +
    +  /**
    +   * Method to remove InExpression node from filter expression
    +   *
    +   * @param expression
    +   */
    +  public void removeInExpressionFromFilterExpression(Expression 
expression) {
    --- End diff --
    
    This method should not belong here.  Better do in scanrdd only


---

Reply via email to