Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1808#discussion_r167119304
  
    --- Diff: 
processing/src/main/java/org/apache/carbondata/processing/util/CarbonLoaderUtil.java
 ---
    @@ -70,6 +79,22 @@
       private CarbonLoaderUtil() {
       }
     
    +  /**
    +   * strategy for assign blocks to nodes/executors
    +   */
    +  public enum BlockAssignmentStrategy {
    +    BLOCK_NUM_FIRST("Assign blocks to node base on number of blocks"),
    +    BLOCK_SIZE_FIRST("Assign blocks to node base on data size of blocks");
    +    private String name;
    +    BlockAssignmentStrategy(String name) {
    +      this.name = name;
    +    }
    +
    +    @Override public String toString() {
    --- End diff --
    
    move @Override to previous line, please follow this in future


---

Reply via email to