Github user manishgupta88 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1984#discussion_r169858244
  
    --- Diff: 
core/src/main/java/org/apache/carbondata/core/datastore/page/SafeDecimalColumnPage.java
 ---
    @@ -217,6 +217,6 @@ public void convertValue(ColumnPageValueConverter 
codec) {
     
       @Override
       public void freeMemory() {
    -
    +    byteArrayData = null;
    --- End diff --
    
    We implemented decimal compression wherein based on precision and scale we 
are storing decimal as integer, short and long. So other types can be used 
based on decimal precision and scale


---

Reply via email to