Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1996#discussion_r170451511
--- Diff:
core/src/main/java/org/apache/carbondata/core/scan/filter/executer/RowLevelFilterExecuterImpl.java
---
@@ -276,12 +277,82 @@ public BitSetGroup applyFilter(BlocksChunkHolder
blockChunkHolder, boolean useBi
public boolean applyFilter(RowIntf value, int dimOrdinalMax)
throws FilterUnsupportedException, IOException {
try {
- return exp.evaluate(value).getBoolean();
+ Boolean result = exp.evaluate(createRow(value,
dimOrdinalMax)).getBoolean();
+ return result == null ? false : result;
} catch (FilterIllegalMemberException e) {
throw new FilterUnsupportedException(e);
}
}
+ /**
+ * create row for row filter to evaluate expression
--- End diff --
describe what is input row and what is the return row
---
