[GitHub] carbondata pull request #1999: [CARBONDATA-2204] Optimized number of reads o...

[xuchuanyin]

Github user xuchuanyin commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1999#discussion_r171121669
  
    --- Diff: 
core/src/main/java/org/apache/carbondata/core/util/path/CarbonTablePath.java ---
    @@ -164,6 +164,14 @@ public static String getMetadataPath(String tablePath) 
{
         return tablePath + File.separator + METADATA_DIR;
       }
     
    +  /**
    +   * Return table status file path based on `tablePath`
    +   */
    +  public static String getTableStatusFilePath(String tablePath) {
    +    return getMetadataPath(tablePath) + 
CarbonCommonConstants.FILE_SEPARATOR
    +        + CarbonCommonConstants.LOADMETADATA_FILENAME;
    --- End diff --
    
    Actually there is a variable called 'TABLE_STATUS_FILE' in Class 
'CarbonTablePath' that represents string ’tablestatus‘, so there is no need 
to use an extra variable 'LOADMETADATA_FILENAME' in Class 
’CarbonCommonConstants‘.  Better to keep only one of them.


---