GitHub user anubhav100 opened a pull request:
https://github.com/apache/carbondata/pull/2034
[CARBONDATA-2288] Exception is Masked Inside
StandardPartitionTableQueryTestCase
**Problem**: Inside This test case exception from both spark version is
different and it is masked
test("Creation of partition table should fail if the colname in table
schema and partition column is same even if both are case sensitive"){
intercept[Exception]
{ sql("CREATE TABLE uniqdata_char2(name char,id int) partitioned by (NAME
char)stored by 'carbondata' ") }
}
for spark 2.1 exception message is
Operation not allowed: Partition columns should not be specified in the
schema: name")
but for spark 2.2 it is
DataType char is not supported"
**Reason**: for different exception in different spark version is
spark 2.1.0 supports creating table even if char data type is given with
out digits
scala> spark.sql("create table id(id char)");
18/02/23 14:12:23 WARN HiveMetaStore: Location:
file:/home/anubhav/Documents/phatak/spark-2.1/bin/spark-warehouse/id specified
for non-external table:id
res0: org.apache.spark.sql.DataFrame = []
but not in spark 2.2.1
scala> spark.sql("create table id(id char)");
18/02/23 14:22:05 WARN ObjectStore: Failed to get database global_temp,
returning NoSuchObjectException
org.apache.spark.sql.catalyst.parser.ParseException:
DataType char is not supported.(line 1, pos 19)
**Solution**: assert the different exception for different spark version
when char data type does not have digit
Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily:
- [ ] Any interfaces changed?
- [ ] Any backward compatibility impacted?
- [ ] Document update required?
- [ ] Testing done
Please provide details on
- Whether new unit test cases have been added or why no new tests
are required?
- How it is tested? Please attach test report.
- Is it a performance related change? Please attach the performance
test report.
- Any additional information to help reviewers in testing this
change.
- [ ] For large changes, please consider breaking it into sub-tasks under
an umbrella JIRA.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/anubhav100/incubator-carbondata
CARBONDATA-2288
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/carbondata/pull/2034.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2034
----
commit b454d3eb732c423e88d9af49c6a4535c9d121110
Author: anubhav100 <anubhav.tarar@...>
Date: 2018-03-06T06:38:48Z
Fixed Exception is Masked Inside StandardPartitionTableQueryTestCase
----
---
