GitHub user xuchuanyin opened a pull request:
https://github.com/apache/carbondata/pull/2037
[CARBONDATA-2232][DataLoad] Fix incorrect logic in spilling unsafe pages to
disk
The unsafe row page will only be written to disk if the memory is
unavailable -- the previous logic just reversed it.
Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily:
- [x] Any interfaces changed?
`NO`
- [x] Any backward compatibility impacted?
`NO`
- [x] Document update required?
`NO`
- [x] Testing done
Please provide details on
- Whether new unit test cases have been added or why no new tests
are required?
- How it is tested? Please attach test report.
- Is it a performance related change? Please attach the performance
test report.
- Any additional information to help reviewers in testing this
change.
- [] For large changes, please consider breaking it into sub-tasks under
an umbrella JIRA.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/xuchuanyin/carbondata
0307_bug_unsafe_sort_savedisk
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/carbondata/pull/2037.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2037
----
commit 87853683e71b6a2f39d4239d9a2e3f396a375033
Author: xuchuanyin <xuchuanyin@...>
Date: 2018-03-07T06:55:51Z
Fix bugs in unsafe row page
The unsafe row page will only be written to disk is the memory is
unavailable -- the previous logic just reversed it.
----
---
