Github user zzcclp commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2045#discussion_r173716693
  
    --- Diff: 
core/src/main/java/org/apache/carbondata/core/statusmanager/SegmentStatusManager.java
 ---
    @@ -834,6 +836,40 @@ private static void 
writeLoadMetadata(AbsoluteTableIdentifier identifier,
         }
       }
     
    +  /**
    +   * Currently the segment lock files are not deleted immediately when 
unlock,
    +   * so it needs to delete expired lock files before delete loads.
    +   */
    +  private static void deleteExpiredSegmentLockFiles(CarbonTable 
carbonTable) {
    --- End diff --
    
    It's better to move this function to CarbonLockUtil.
    Done


---

Reply via email to