GitHub user xuchuanyin opened a pull request:
https://github.com/apache/carbondata/pull/2059
[CARBONDATA-2250][DataLoad] Reduce massive object generation in global sort
Generate compatator outside the function, otherwise it will be generated
for every row
Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily:
- [x] Any interfaces changed?
`NO`
- [x] Any backward compatibility impacted?
`NO`
- [x] Document update required?
`NO`
- [x] Testing done
Please provide details on
- Whether new unit test cases have been added or why no new tests
are required?
`NO`
- How it is tested? Please attach test report.
`Tested in local machine`
- Is it a performance related change? Please attach the performance
test report.
`Performance should be slightly enhanced`
- Any additional information to help reviewers in testing this
change.
- [x] For large changes, please consider breaking it into sub-tasks under
an umbrella JIRA.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/xuchuanyin/carbondata
0313_optimize_global_sort_comparator
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/carbondata/pull/2059.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2059
----
commit b4d4d7a945949cec02064466e53f3b18d576fd58
Author: xuchuanyin <xuchuanyin@...>
Date: 2018-03-13T07:49:48Z
Reduce massive object generation in global sort
generate compatator outside the function, otherwise it will be generated
for every row
----
---
