Github user kunal642 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1856#discussion_r174060559
  
    --- Diff: 
integration/spark-common-test/src/test/scala/org/apache/carbondata/integration/spark/testsuite/timeseries/TestTimeSeriesCreateTable.scala
 ---
    @@ -17,18 +17,28 @@
     package org.apache.carbondata.integration.spark.testsuite.timeseries
     
     import org.apache.spark.sql.AnalysisException
    +import org.apache.spark.sql.catalyst.analysis.TableAlreadyExistsException
     import org.apache.spark.sql.test.util.QueryTest
    -import org.scalatest.BeforeAndAfterAll
    +import org.scalatest.{BeforeAndAfterAll, BeforeAndAfterEach}
     
     import 
org.apache.carbondata.common.exceptions.sql.{MalformedCarbonCommandException, 
MalformedDataMapCommandException}
    +import org.apache.carbondata.core.constants.CarbonCommonConstants
     import 
org.apache.carbondata.core.metadata.schema.datamap.DataMapProvider.TIMESERIES
    +import org.apache.carbondata.core.util.CarbonProperties
     
    -class TestTimeSeriesCreateTable extends QueryTest with BeforeAndAfterAll {
    +class TestTimeSeriesCreateTable extends QueryTest with BeforeAndAfterAll 
with BeforeAndAfterEach{
     
       val timeSeries = TIMESERIES.toString
    +  var timestampFormat: String = _
    --- End diff --
    
    no need for this variable. simply set 
CarbonCommonConstants.CARBON_TIMESTAMP_DEFAULT_FORMAT as the timestamp format 
is after all.


---

Reply via email to