Github user xubo245 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1856#discussion_r174130738
  
    --- Diff: 
integration/spark-common-test/src/test/scala/org/apache/carbondata/spark/testsuite/sortcolumns/TestSortColumns.scala
 ---
    @@ -33,16 +33,15 @@ class TestSortColumns extends QueryTest with 
BeforeAndAfterAll {
           CarbonCommonConstants.CARBON_TIMESTAMP_FORMAT, "dd-MM-yyyy")
     
         SparkUtil4Test.createTaskMockUp(sqlContext)
    -    dropTable
         CarbonProperties.getInstance()
           .addProperty(CarbonCommonConstants.CARBON_TIMESTAMP_FORMAT, 
"dd-MM-yyyy")
    +    dropTestTables
    --- End diff --
    
    I add common method QueryTest for all test case in 
org.apache.spark.sql.test.util.QueryTest, so subclass should change the method 
name


---

Reply via email to