[GitHub] carbondata pull request #2057: [CARBONDATA-2248]Fixed Memory leak in parser/...

[jackylk]

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2057#discussion_r174204132
  
    --- Diff: 
integration/spark2/src/main/scala/org/apache/spark/sql/parser/CarbonSparkSqlParser.scala
 ---
    @@ -52,9 +52,12 @@ class CarbonSparkSqlParser(conf: SQLConf, sparkSession: 
SparkSession) extends Ab
       override def parsePlan(sqlText: String): LogicalPlan = {
         CarbonSession.updateSessionInfoToCurrentThread(sparkSession)
         try {
    -      super.parsePlan(sqlText)
    +      val parsedPlan = super.parsePlan(sqlText)
    +      CarbonScalaUtil.cleanParserThreadLocals
    --- End diff --
    
    Why not add it in finally block?


---