[GitHub] carbondata pull request #2103: [WIP]Support In Memory Catalog

[xubo245]

Github user xubo245 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2103#discussion_r177729364
  
    --- Diff: 
integration/spark2/src/main/scala/org/apache/spark/sql/CarbonSession.scala ---
    @@ -124,15 +127,30 @@ object CarbonSession {
           getOrCreateCarbonSession(null, null)
         }
     
    +    def getOrCreateCarbonSessionWithOutHive(): SparkSession = {
    +      getOrCreateCarbonSession(null, null, false)
    +    }
    +
         def getOrCreateCarbonSession(storePath: String): SparkSession = {
           getOrCreateCarbonSession(
             storePath,
             new 
File(CarbonCommonConstants.METASTORE_LOCATION_DEFAULT_VAL).getCanonicalPath)
         }
     
    +    def getOrCreateCarbonSessionWithOutHive(storePath: String): 
SparkSession = {
    +      getOrCreateCarbonSession(storePath, null, false)
    +    }
    +
         def getOrCreateCarbonSession(storePath: String,
    -        metaStorePath: String): SparkSession = synchronized {
    -      builder.enableHiveSupport()
    +        metaStorePath: String): SparkSession = {
    +      getOrCreateCarbonSession(storePath, metaStorePath)
    --- End diff --
    
    Here code circulation, it will lead to java.lang.StackOverflowError


---