GitHub user BJangir opened a pull request:
https://github.com/apache/carbondata/pull/2121
[CARBONDATA-2275]Query Failed for 0 byte deletedelta file
When delete is failed on write step because of any exception from hdfs .
Currently 0 bye deletedelta file is created and not getting cleaned up .
So when any Select Query is triggered , Select Query is failed
Root Cause:-
deletedelta of 0 size was considered for reader and while getting the
hostname it has thrown IndexOutofBound
Even Writer is failed while flush /close (exception from hdfs) but
Exception is not thrown back to caller which is making delete operation is
success.
Solution :-
While reading ignore 0 size deletedelta file
When Writer is failed ,Throw Failure Exception to caller and show error on
query client .
deletedelta of 0 byte will be handled in cleanup automatically in next
delete/update .
Any interfaces changed?
NA
Any backward compatibility impacted?
NA
Document update required?
NA
Testing done
Please provide details on
- Whether new unit test cases have been added or why no new tests are
required?
- How it is tested? Please attach test report.
- Is it a performance related change? Please attach the performance test
report.
- Any additional information to help reviewers in testing this change.
Testing is Done Manually.
For large changes, please consider breaking it into sub-tasks under an
umbrella JIRA.
NA
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/BJangir/incubator-carbondata deletelta_0
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/carbondata/pull/2121.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2121
----
commit a159bd1626267c17de3b4e12593d7ee0d69657cc
Author: BJangir <babulaljangir111@...>
Date: 2018-03-23T17:19:27Z
[CARBONDATA-2275]Query Failed for 0 byte deletedelta file
----
---
