Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2136#discussion_r179080396
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/chunk/impl/DimensionRawColumnChunk.java
---
@@ -106,9 +106,13 @@ public DimensionColumnPage
convertToDimColDataChunkWithOutCache(int index) {
for (int i = 0; i < dataChunks.length; i++) {
if (dataChunks[i] != null) {
dataChunks[i].freeMemory();
+ dataChunks[i] = null;
}
}
}
+ if (rawData != null) {
+ rawData = null;
+ }
--- End diff --
No need for null check as rawData is being set only to null. Better to
implement freeMemory method in super class AbstractRawColumnChunk and set
rawData to null in that and call super.freeMemory() from child classes.
---
