Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2134#discussion_r179341377
--- Diff:
core/src/main/java/org/apache/carbondata/core/indexstore/UnsafeMemoryDMStore.java
---
@@ -52,11 +62,23 @@
private final long taskId =
ThreadLocalTaskInfo.getCarbonTaskInfo().getTaskId();
- public UnsafeMemoryDMStore(CarbonRowSchema[] schema) throws
MemoryException {
+ private boolean addRowToUnsafe = true;
--- End diff --
Class name itself `UnsafeMemoryDMStore` so it does not make sense to have
this variable.
Please create AbstractClass and give two implementations with safe and
Unsafe.
---