Github user gvramana commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2131#discussion_r179361367
--- Diff:
core/src/main/java/org/apache/carbondata/core/readcommitter/TableStatusReadCommittedScope.java
---
@@ -0,0 +1,76 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.carbondata.core.readcommitter;
+
+import java.io.IOException;
+import java.util.Map;
+
+import org.apache.carbondata.common.annotations.InterfaceAudience;
+import org.apache.carbondata.common.annotations.InterfaceStability;
+import org.apache.carbondata.core.datamap.Segment;
+import
org.apache.carbondata.core.indexstore.blockletindex.SegmentIndexFileStore;
+import org.apache.carbondata.core.metadata.AbsoluteTableIdentifier;
+import org.apache.carbondata.core.metadata.SegmentFileStore;
+import org.apache.carbondata.core.statusmanager.LoadMetadataDetails;
+import org.apache.carbondata.core.statusmanager.SegmentStatusManager;
+import org.apache.carbondata.core.util.path.CarbonTablePath;
+
+/**
+ * ReadCommittedScope for the managed carbon table
+ */
[email protected]
[email protected]
+public class TableStatusReadCommittedScope implements ReadCommittedScope {
+ private LoadMetadataDetails[] loadMetadataDetails;
+ private AbsoluteTableIdentifier identifier;
+
+ public TableStatusReadCommittedScope(AbsoluteTableIdentifier identifier)
{
+ this.identifier = identifier;
+ takeCarbonIndexFileSnapShot();
+ }
+
+ @Override public LoadMetadataDetails[] getSegmentList() throws
IOException {
+ try {
+ this.loadMetadataDetails = SegmentStatusManager
+
.readTableStatusFile(CarbonTablePath.getTableStatusFilePath(identifier.getTablePath()));
+ return this.loadMetadataDetails;
+ } catch (IOException ex) {
+ this.loadMetadataDetails = new LoadMetadataDetails[0];
--- End diff --
should throw exception here, it is not valid behaviour to return empty list
---