Github user chenliang613 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2139#discussion_r180553823
  
    --- Diff: 
integration/presto/src/main/java/org/apache/carbondata/presto/PrestoFilterUtil.java
 ---
    @@ -69,6 +72,13 @@
     
       private static Map<Integer, Expression> filterMap = new HashMap<>();
     
    +  private final static String HIVE_DEFAULT_DYNAMIC_PARTITION = 
"__HIVE_DEFAULT_PARTITION__";
    --- End diff --
    
    can you explain, why need to add "HIVE_DEFAULT_DYNAMIC_PARTITION" ? what 
purpose?
    if (value == null) {
            filter.add(carbonDataColumnHandle.getColumnName() + "=" + 
HIVE_DEFAULT_DYNAMIC_PARTITION);


---

Reply via email to