Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2163#discussion_r180990390
  
    --- Diff: 
streaming/src/main/scala/org/apache/carbondata/streaming/StreamSinkFactory.scala
 ---
    @@ -45,11 +50,41 @@ import 
org.apache.carbondata.streaming.segment.StreamSegment
      */
     object StreamSinkFactory {
     
    +  val LOGGER = 
LogServiceFactory.getLogService(this.getClass.getCanonicalName)
    +
    +  val locks = new util.concurrent.ConcurrentHashMap[String, ICarbonLock]()
    +
    +  def lock(carbonTable: CarbonTable): Unit = {
    --- End diff --
    
    I think it is not intuitive to have lock/unlock function in a Factory 
class. Can you put it in other place


---

Reply via email to