GitHub user xuchuanyin opened a pull request:
https://github.com/apache/carbondata/pull/2169
[CARBONDATA-2344][DataMap] Fix bugs in mapping blocklet to UnsafeDMStore
rows
In BlockletDataMap, carbondata stores DMRow in an array for each
blocklet. But currently carbondata accesses the DMRow only by
blockletId(0, 1, etc.), which will cause problem since different
block can have same blockletId.
This PR adds a map to map the blockId#blockletId to array index,
carbondata can access the DMRow by blockId and blockletId.
Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily:
- [x] Any interfaces changed?
`NO, only internal interfaces have been changed`
- [x] Any backward compatibility impacted?
`NO`
- [x] Document update required?
`NO`
- [x] Testing done
Please provide details on
- Whether new unit test cases have been added or why no new tests
are required?
`NO`
- How it is tested? Please attach test report.
`Tested in local`
- Is it a performance related change? Please attach the performance
test report.
`No`
- Any additional information to help reviewers in testing this
change.
`NO`
- [x] For large changes, please consider breaking it into sub-tasks under
an umbrella JIRA.
`Not related`
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/xuchuanyin/carbondata
0413_bug_blocklet_dm_unsafe_row
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/carbondata/pull/2169.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2169
----
commit dd010297c7f7428dc8f42ec1a292b8cdddcc09aa
Author: xuchuanyin <xuchuanyin@...>
Date: 2018-04-13T08:18:23Z
Fix bugs in mapping blocklet to UnsafeDMStore
In BlockletDataMap, carbondata stores DMRow in an array for each
blocklet. But currently carbondata accesses the DMRow only by
blockletId(0, 1, etc.), which will cause problem since different
block can have same blockletId.
This PR adds a map to map the blockId#blockletId to array index,
carbondata can access the DMRow by blockId and blockletId.
----
---
