Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2113#discussion_r181399425
  
    --- Diff: 
integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/datamap/CarbonCreateDataMapCommand.scala
 ---
    @@ -69,11 +69,33 @@ case class CarbonCreateDataMapCommand(
         }
     
         dataMapSchema = new DataMapSchema(dataMapName, dmClassName)
    -    if (mainTable != null &&
    -        mainTable.isStreamingTable &&
    -        
!(dataMapSchema.getProviderName.equalsIgnoreCase(DataMapClassProvider.PREAGGREGATE.toString)
    -          || dataMapSchema.getProviderName
    -            .equalsIgnoreCase(DataMapClassProvider.TIMESERIES.toString))) {
    +    if 
(dataMapSchema.getProviderName.equalsIgnoreCase(DataMapClassProvider.LUCENEFG.toString)
 ||
    --- End diff --
    
    I think we should abstract interface for it. We can not add if check for 
every new datamap added


---

Reply via email to