Github user kumarvishal09 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2160#discussion_r181716090
  
    --- Diff: 
integration/spark-common/src/main/scala/org/apache/spark/sql/execution/streaming/CarbonAppendableStreamSink.scala
 ---
    @@ -163,7 +162,7 @@ class CarbonAppendableStreamSink(
       /**
        * if the directory size of current segment beyond the threshold, hand 
off new segment
        */
    -  private def checkOrHandOffSegment(): Unit = {
    +  private def checkOrHandOffSegment(operationContext: OperationContext): 
Unit = {
    --- End diff --
    
    No need to change method signature use the same operation context passed in 
CarbonAppendableStreamSink


---

Reply via email to