Github user xubo245 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2148#discussion_r182719725
  
    --- Diff: 
store/search/src/main/java/org/apache/carbondata/store/worker/SearchRequestHandler.java
 ---
    @@ -93,10 +93,13 @@ public ShutdownResponse handleShutdown(ShutdownRequest 
request) {
         List<CarbonRow> rows = new LinkedList<>();
         try {
           while (reader.nextKeyValue()) {
    -        rows.add(reader.getCurrentValue());
    +        // copy the data as the reader may reuse the same buffer, if 
unsafe is enabled
    +        rows.add(new CarbonRow(reader.getCurrentValue().getData()));
    --- End diff --
    
    This commit will lead to JVM crash in my local machine. After revert, it 
will running success.


---

Reply via email to