[GitHub] carbondata pull request #2187: [CARBONDATA-2362] Changing the Cacheable obje...

[ravipesala]

Github user ravipesala commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2187#discussion_r182937982
  
    --- Diff: 
core/src/main/java/org/apache/carbondata/core/indexstore/BlockletDetailInfo.java
 ---
    @@ -83,6 +84,22 @@ public void setVersionNumber(short versionNumber) {
       }
     
       public BlockletInfo getBlockletInfo() {
    +    if (null == blockletInfo && null != blockletInfoBinary && 
blockletInfoBinary.length > 0) {
    +      blockletInfo = new BlockletInfo();
    +      ByteArrayInputStream stream = new 
ByteArrayInputStream(blockletInfoBinary);
    +      DataInputStream inputStream = new DataInputStream(stream);
    +      try {
    +        blockletInfo.readFields(inputStream);
    +      } catch (IOException e) {
    +        e.printStackTrace();
    +      } finally {
    +        try {
    +          inputStream.close();
    +        } catch (IOException e) {
    +          e.printStackTrace();
    --- End diff --
    
    remove it and throw exception


---