Github user gvramana commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2177#discussion_r183043670
  
    --- Diff: 
processing/src/main/java/org/apache/carbondata/processing/util/CarbonLoaderUtil.java
 ---
    @@ -169,8 +169,28 @@ public static boolean 
recordNewLoadMetadata(LoadMetadataDetails newMetaEntry,
        * @throws IOException
        */
       public static boolean recordNewLoadMetadata(LoadMetadataDetails 
newMetaEntry,
    -      CarbonLoadModel loadModel, boolean loadStartEntry, boolean 
insertOverwrite, String uuid)
    +      final CarbonLoadModel loadModel, boolean loadStartEntry, boolean 
insertOverwrite, String uuid)
           throws IOException {
    +    if (loadModel.isCarbonNonTransactionalTable()) {
    --- End diff --
    
    Function name says updation of metadata, so should not delete data in that


---

Reply via email to