Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2204#discussion_r183230061
  
    --- Diff: 
core/src/main/java/org/apache/carbondata/core/datamap/DataMapChooser.java ---
    @@ -93,6 +93,48 @@ public DataMapExprWrapper choose(CarbonTable 
carbonTable, FilterResolverIntf res
             resolverIntf);
       }
     
    +  /**
    +   * Return a chosen datamap based on input filter. See {@link 
DataMapChooser}
    +   */
    +  public DataMapExprWrapper chooseFG(CarbonTable carbonTable, 
FilterResolverIntf resolverIntf)
    --- End diff --
    
    I think better to rename to `chooseFGDataMap`


---

Reply via email to