Github user ravipesala commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2191#discussion_r183342483
  
    --- Diff: 
core/src/main/java/org/apache/carbondata/core/scan/result/impl/NonFilterQueryScannedResult.java
 ---
    @@ -48,6 +53,31 @@ public NonFilterQueryScannedResult(BlockExecutionInfo 
blockExecutionInfo) {
         return getDictionaryKeyIntegerArray(currentRow);
       }
     
    +  @Override public List<byte[]> getDictionaryKeyArrayBatch(int batchSize) {
    +    ++currentRow;
    --- End diff --
    
    Is this increment is intentional? Because increment as per batch size is 
already happening in `RawBasedResultCollector`


---

Reply via email to