Github user gvramana commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2212#discussion_r183374584
  
    --- Diff: 
core/src/main/java/org/apache/carbondata/core/indexstore/blockletindex/BlockletDataMapFactory.java
 ---
    @@ -103,6 +105,53 @@ public DataMapWriter createWriter(Segment segment, 
String writeDirectoryPath) {
                     indexFile.getName(), indexFileEntry.getValue(), 
segment.getSegmentNo()));
           }
           segmentMap.put(segment.getSegmentNo(), 
tableBlockIndexUniqueIdentifiers);
    +    } else {
    --- End diff --
    
    This should not be handled using list if files, check at datamap. this 
logic is common for all data maps. So should be handled using segment update 
time.


---

Reply via email to