GitHub user manishgupta88 opened a pull request:
https://github.com/apache/carbondata/pull/2217
[CARBONDATA-2391] [Compaction Thread Leak] Thread leak in compaction
operation if prefetch is enabled and compaction process is killed
Problem
Thread leak in compaction operation if prefetch is enabled and compaction
process is killed
Analysis
During compaction if prefetch is enabled RawResultIterator launches an
executor service for prefetching the data.
If compactions fails or the process is killed it can lead to thread leak
due to executor service still in running state.
Fix
Close the executor service in task completion listener of compaction
Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily:
- [ ] Any interfaces changed?
- [ ] Any backward compatibility impacted?
- [ ] Document update required?
- [ ] Testing done
Please provide details on
- Whether new unit test cases have been added or why no new tests
are required?
- How it is tested? Please attach test report.
- Is it a performance related change? Please attach the performance
test report.
- Any additional information to help reviewers in testing this
change.
- [ ] For large changes, please consider breaking it into sub-tasks under
an umbrella JIRA.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/manishgupta88/carbondata
thread_leak_compaction_fix
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/carbondata/pull/2217.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2217
----
commit e24883b7f0d460c58c6d1773de4aa38ec757585a
Author: manishgupta88 <tomanishgupta18@...>
Date: 2018-04-23T14:59:56Z
Problem
Thread leak in compaction operation if prefetch is enabled and compaction
process is killed
Analysis
During compaction if prefetch is enabled RawResultIterator launches an
executor service for prefetching the data.
If compactions fails or the process is killed it can lead to thread leak
due to executor service still in running state.
Fix
Close the executor service in task completion listener of compaction
----
---
