Github user ravipesala commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2180#discussion_r184322994
  
    --- Diff: 
core/src/main/java/org/apache/carbondata/core/scan/expression/ColumnExpression.java
 ---
    @@ -132,5 +132,8 @@ public void setCarbonColumn(CarbonColumn carbonColumn) {
       public void findAndSetChild(Expression oldExpr, Expression newExpr) {
       }
     
    +  @Override public int getMaxDoc() {
    --- End diff --
    
    Don't add this method here, it is very specific to lucene. So only add this 
in that lucene expression.


---

Reply via email to