Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2210#discussion_r184327009
--- Diff:
core/src/main/java/org/apache/carbondata/core/scan/collector/ResultCollectorFactory.java
---
@@ -45,31 +46,37 @@
* @return
*/
public static AbstractScannedResultCollector getScannedResultCollector(
- BlockExecutionInfo blockExecutionInfo) {
+ BlockExecutionInfo blockExecutionInfo, QueryStatisticsModel
queryStatisticsModel) {
--- End diff --
I think it is better to pass in constructor instead of making the
blockExecutionInfo object more heavier. Also because the QueryStatisticsModel
is at the reader level and one reader can have multiple blocks so in my opinion
keeping in blockExecutionInfo will not be a good idea.
---
