Github user manishgupta88 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1812#discussion_r184398253
  
    --- Diff: 
integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/management/CarbonAlterTableCompactionCommand.scala
 ---
    @@ -212,13 +224,18 @@ case class CarbonAlterTableCompactionCommand(
         carbonLoadModel.setFactTimeStamp(loadStartTime)
     
         val isCompactionTriggerByDDl = true
    +    var segmentIds: Option[List[String]] = None
    +    if (compactionType == CompactionType.CUSTOM && 
alterTableModel.customSegmentIds.isDefined) {
    +      segmentIds = alterTableModel.customSegmentIds
    +    }
         val compactionModel = CompactionModel(compactionSize,
           compactionType,
           carbonTable,
           isCompactionTriggerByDDl,
           CarbonFilters.getCurrentPartitions(sqlContext.sparkSession,
             TableIdentifier(carbonTable.getTableName,
    -        Some(carbonTable.getDatabaseName)))
    +        Some(carbonTable.getDatabaseName))),
    +      segmentIds
    --- End diff --
    
    Please check for code alignment here. It does not seem to be proper


---

Reply via email to